Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onVisibleDateRangeChange is not subscriber on visibleDateRangeChange event but separated method #7203

Closed
chuckn0rris opened this issue Jul 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@chuckn0rris
Copy link

Forum post

Try to subscribe on visibleDateRangeChange event with 'on' notation

        onVisibleDateRangeChange(event) {
            debugger
        },

See that params list contains only range and nothing else. Sometimes that range has incorrect dates. In the code it's clear that there is a onVisibleDateRangeChange method exists that is not a listener.

@chuckn0rris chuckn0rris added bug Something isn't working premium forum Issues from forum large-account Reported by large customer OEM OEM customer labels Jul 24, 2023
@isglass
Copy link
Contributor

isglass commented Jul 24, 2023

Should probably rename the internal fn to internalOnVisibleDateRangeChange

@isglass isglass added the high-priority Urgent to have fixed label Jul 24, 2023
@canonic-epicure canonic-epicure self-assigned this Jul 25, 2023
@canonic-epicure canonic-epicure added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Jul 27, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Aug 1, 2023
@isglass isglass added this to the 5.5.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants