Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong typing for record.setAsync method #7207

Closed
chuckn0rris opened this issue Jul 24, 2023 · 0 comments
Closed

Wrong typing for record.setAsync method #7207

chuckn0rris opened this issue Jul 24, 2023 · 0 comments
Assignees
Labels
bug Something isn't working docs Improvements or additions to documentation forum Issues from forum large-account Reported by large customer resolved Fixed but not yet released (available in the nightly builds) typescript
Milestone

Comments

@chuckn0rris
Copy link

Fix in docs param def
value to [value]

  • @param {*} [value] Value to set
    Here:
    ResourceModelMixin.js
    EventModelMixin.js
    AssignmentModelMixin.js
    DependencyBaseModel.js

Check if any other places required to be updated. Check set method as well

Forum post

PS: in Scheduler.d.ts

for the setAsync

    setAsync(field: string|object, value: any, silent?: boolean): Promise<void>;

value is marked as any instead not mandatory when field is an object.
should be like this:

    setAsync(field: string|object, value?: any, silent?: boolean): Promise<void>;
@chuckn0rris chuckn0rris added bug Something isn't working docs Improvements or additions to documentation forum Issues from forum typescript large-account Reported by large customer labels Jul 24, 2023
@mazzafabio mazzafabio added in progress ready for review Issue is fixed, the pull request is being reviewed labels Jul 26, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed in progress ready for review Issue is fixed, the pull request is being reviewed labels Aug 10, 2023
@isglass isglass added this to the 5.5.1 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation forum Issues from forum large-account Reported by large customer resolved Fixed but not yet released (available in the nightly builds) typescript
Projects
None yet
Development

No branches or pull requests

3 participants