Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollOptions typings problem for thin bundle #7385

Closed
chuckn0rris opened this issue Aug 28, 2023 · 0 comments
Closed

ScrollOptions typings problem for thin bundle #7385

chuckn0rris opened this issue Aug 28, 2023 · 0 comments
Assignees
Labels
api change API change forum Issues from forum large-account Reported by large customer OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds) typescript
Milestone

Comments

@chuckn0rris
Copy link

Forum post

Basically as the title says - when using the scrollToDate in scheduler, the option type is defined as ScrollOptions. It should probably be ScrollIntoViewOptions.

TypeScript started to complain about this as we are migrating from using the full bundle to the new thin npm bundles as shipped with 5.6.0-alpha-1.

Skärmavbild 2023-08-25 kl. 12.39.36.png
Skärmavbild 2023-08-25 kl. 12.39.36.png

I investigated it a little deeper, and I think the issue is that the scheduler.d.ts in scheduler-thin does not import ScrollOptions from core-thin, but is rather relying on a TypeScript global type called ScrollOptions. If you make sure to add ScrollOptions from core-thin among your imported types, it should behave correctly.

@chuckn0rris chuckn0rris added bug Something isn't working premium forum Issues from forum typescript large-account Reported by large customer OEM OEM customer labels Aug 28, 2023
@SergeyMaltsev SergeyMaltsev added this to the 5.6.0-alpha-2 milestone Aug 29, 2023
@SergeyMaltsev SergeyMaltsev added api change API change resolved Fixed but not yet released (available in the nightly builds) and removed bug Something isn't working labels Aug 29, 2023
@SergeyMaltsev SergeyMaltsev modified the milestones: 5.6.0-alpha-2, 5.6.0 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change API change forum Issues from forum large-account Reported by large customer OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds) typescript
Projects
None yet
Development

No branches or pull requests

2 participants