Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onChange function becomes field in SchedulerPro ProjectModel #7457

Closed
jsakalos opened this issue Sep 7, 2023 · 1 comment
Closed

onChange function becomes field in SchedulerPro ProjectModel #7457

jsakalos opened this issue Sep 7, 2023 · 1 comment
Assignees
Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@jsakalos
Copy link

jsakalos commented Sep 7, 2023

When we define onChange on ProjectModel like this:

    project : {
        autoLoad  : true,
        transport : {
            load : {
                url : 'data/data.json'
            }
        },
        onChange : () => {
            console.log('here we are');
        }

it will become a DataField on instantiation. That can cause the scheduler to crash such as here: #7454

Screenshot 2023-09-07 at 14 39 53
@jsakalos jsakalos added the bug Something isn't working label Sep 7, 2023
@isglass isglass added the high-priority Urgent to have fixed label Sep 7, 2023
@isglass
Copy link
Contributor

isglass commented Sep 7, 2023

ProjectModel should probably not autoExpose fields

@bmblb bmblb added ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Sep 27, 2023
@SergeyMaltsev SergeyMaltsev removed their assignment Sep 27, 2023
@bmblb bmblb added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Oct 30, 2023
@bmblb bmblb added this to the 5.6.1 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants