Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REACT] Gantt crashes when using TAB in custom editors #7509

Closed
taauntik opened this issue Sep 15, 2023 · 0 comments
Closed

[REACT] Gantt crashes when using TAB in custom editors #7509

taauntik opened this issue Sep 15, 2023 · 0 comments
Assignees
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@taauntik
Copy link

Forum post

Hi,

See attached sample and video demonstrating the problem.

When we change a value in a cell and press TAB to jump to the next cell, an exception is thrown, and Gantt is left in a broken state, if there is a read-only cell between the cell losing focus and the one receiving focus. This only happens when using custom controls to edit data and with modern versions of React.

This bug is critical - we rely heavily on custom controls for editing.

I would once again like to request that you upgrade from React 16.4 to 18.2 so bugs like these can be caught on your end. React 16 is 3 years old and is not compatible with modern versions of React.
https://legacy.reactjs.org/blog/2020/08/10/react-v17-rc.html

callStack

WrapperHelper.tsx:558 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'focus')
    at wrapperWidget.focus (WrapperHelper.tsx:558:1)
    at Editor.startEdit (gantt.module.js:66355:1)
    at async CellEdit3.startEditing (gantt.module.js:78062:1)
    at async CellEdit3.startEditing (gantt.module.js:164128:1)
    at async CellEdit3.finishAndEditNextCell (gantt.module.js:78349:1)
    at async CellEdit3.finishAndEditNextCell (gantt.module.js:78350:1)
Reproduced.mp4

Reproducible with this

Bryntum-2023-09-14-004.zip

@taauntik taauntik added bug Something isn't working high-priority Urgent to have fixed premium forum Issues from forum large-account Reported by large customer OEM OEM customer labels Sep 15, 2023
@matsbryntse matsbryntse added this to the 5.5.4 milestone Sep 15, 2023
@jsakalos jsakalos added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Sep 18, 2023
@SergeyMaltsev SergeyMaltsev added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed BLOCKING labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants