Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onBeforeDragMoveEnd returns incorrect datetime on event record #7587

Closed
chuckn0rris opened this issue Sep 28, 2023 · 2 comments
Closed

onBeforeDragMoveEnd returns incorrect datetime on event record #7587

chuckn0rris opened this issue Sep 28, 2023 · 2 comments
Assignees
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@chuckn0rris
Copy link

Forum post

Background

I am upgrading from v5.3.5 to v5.5.3 to test out the fix for:
#7059 – beforeDragMoveEnd and beforeDragResizeEnd has not correct event ids

Issue

There seems to be a change in the returned date for the onBeforeDragMoveEnd callback. On v5.3.5, when I drag a 1:30PM to 2:00PM event to 2:00PM to 2:30PM, the callback returns the correct updated datetime (2:00PM to 2:30PM).

Screenshot 2023-09-25 at 12.57.23 PM.png

On v5.5.3, using the same example, the callback does not return the updated date time (it returns 1:30PM to 2:00PM).

Screenshot 2023-09-25 at 1.03.03 PM.png

This is not ideal for us because we need to upgrade to receive the correct event IDs, but at the same time, the callback seems to now be returning the wrong datetime.

Code

            <BryntumCalendar
                ref={calendar}
                project={project}
                onBeforeDragMoveEnd={({eventRecord}) => {
                              const { startDate, endDate } = eventRecord;
                              console.log('startDate', startDate);
                              console.log('endDate', endDate);
                }}
            />

Screenshot 2023-09-25 at 12.57.23 PM.png
Screenshot 2023-09-25 at 1.03.03 PM.png

@chuckn0rris chuckn0rris added bug Something isn't working regression Worked previously, now broken forum Issues from forum large-account Reported by large customer OEM OEM customer labels Sep 28, 2023
@matsbryntse matsbryntse added the high-priority Urgent to have fixed label Oct 2, 2023
@mazzafabio mazzafabio self-assigned this Oct 5, 2023
@mazzafabio mazzafabio added in progress ready for review Issue is fixed, the pull request is being reviewed labels Oct 5, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed in progress ready for review Issue is fixed, the pull request is being reviewed labels Oct 11, 2023
@isglass isglass added this to the 5.5.5 milestone Oct 11, 2023
@marciogurka
Copy link

Still reproducible on 5.6.9 (just added the onBeforeDragMoveEnd listener to the basic React demo)

11.04.2024_15.25.17_REC.mp4

@marciogurka marciogurka reopened this Apr 11, 2024
@marciogurka
Copy link

Just saw the new parameters, so, I'll close again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

5 participants