Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "aria-pressed" only for toggle button and not all buttons #7588

Closed
marciogurka opened this issue Sep 29, 2023 · 0 comments
Closed

Add "aria-pressed" only for toggle button and not all buttons #7588

marciogurka opened this issue Sep 29, 2023 · 0 comments
Assignees
Labels
bug Something isn't working forum Issues from forum OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@marciogurka
Copy link

Forum post

"Hi Bryntum Team,
We have a button added on one of our columns of the grid. When we tested it with Narrator, it read it as "Toggle Button" while it's not a toggle button. We have tried setting aria-pressed=null and it worked properly. But I think the aria-pressed attribute should not be added to the button element unless the button is configured as toggleable."

Checking MDN docs we have

Adding aria-pressed to an element with a role of button turns the button into a toggle button. The aria-pressed attribute is only relevant for toggle buttons. It represents the button's current "pressed" state.

So, it makes sense to have aria-pressed added only when it's a toggle button.

@marciogurka marciogurka added bug Something isn't working premium forum Issues from forum OEM OEM customer labels Sep 29, 2023
@matsbryntse matsbryntse self-assigned this Oct 8, 2023
@matsbryntse matsbryntse added the ready for review Issue is fixed, the pull request is being reviewed label Oct 8, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Oct 9, 2023
@isglass isglass added this to the 5.5.5 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum OEM OEM customer premium resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants