Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection checkbox stays checked if beforeSelectionChange returns false #7593

Closed
arcady-zherdev opened this issue Sep 29, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@arcady-zherdev
Copy link

arcady-zherdev commented Sep 29, 2023

Most probably is a Grid level issue but reproduced in the Gantt advanced demo. Steps:

  1. modify assignment column like this:
new Gantt({
    columns : [
        {
            type : 'resourceassignment',
            width : 120,
            editor : {
                picker : {
                    listeners : {
                        beforeSelectionChange({ action, mode, selected }) {
                            // prevent assigning resource with id===7
                            return !selected.find(rec => rec.resourceId === 7)
                        }
                    },
                }
            }
        },
......
  1. it prevent assigning resource Dan
  2. but if you check it it stays checked even though not included into selection
@arcady-zherdev arcady-zherdev added the bug Something isn't working label Sep 29, 2023
@matsbryntse matsbryntse self-assigned this Oct 1, 2023
@matsbryntse matsbryntse added ready for review Issue is fixed, the pull request is being reviewed resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Oct 1, 2023
@matsbryntse matsbryntse added this to the 5.5.4 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

2 participants