Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskEdit stops working if hideAnimationEnd event is not fired #7726

Closed
matsbryntse opened this issue Oct 23, 2023 · 0 comments
Closed

TaskEdit stops working if hideAnimationEnd event is not fired #7726

matsbryntse opened this issue Oct 23, 2023 · 0 comments
Assignees
Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@matsbryntse
Copy link
Member

Needs a timeout as a fallback

onBeforeHide({ source, animate }) {
        // It should not matter that we might override previous promise. Any chained promises still are going to be
        // executed. We only need to make sure that current promise and doCancel promises end at the same time.
        if (source.hideAnimation && animate !== false) {
            this._hiding = new Promise(resolve => {
                source.ion({ hideAnimationEnd : resolve });
            }).finally(() => this._hiding = undefined);
        }
    }
@matsbryntse matsbryntse added bug Something isn't working high-priority Urgent to have fixed labels Oct 23, 2023
@mazzafabio mazzafabio self-assigned this Oct 26, 2023
@mazzafabio mazzafabio added in progress ready for review Issue is fixed, the pull request is being reviewed labels Oct 26, 2023
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed in progress ready for review Issue is fixed, the pull request is being reviewed labels Nov 21, 2023
@isglass isglass added this to the 5.6.2 milestone Nov 21, 2023
@isglass isglass closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants