Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make column renderer more efficient #7883

Closed
taauntik opened this issue Nov 16, 2023 · 1 comment
Closed

Make column renderer more efficient #7883

taauntik opened this issue Nov 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer performance premium resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@taauntik
Copy link

Forum Post

Hi Bryntum Team,

I just noticed a behavior in the Scheduler that was surprising to me.
The scenario is that I add a custom renderer to a column (below is the code that you can add to the basic scheduler demo, I just added a console log when the renderer is being triggered). Now, there are two things:

  1. On every small resize of an event (e.g., just by 1px) a rerender of the complete row (in which the event is being resized) is triggered (1 log per resize)
  2. If I drop an event, all (!) rows are being rerendered (10 logs per event drop)

I am wondering, why is it necessary to rerender the columns in both cases anyways, since from my understanding only the event representation changes. For instance, if I have some more or less "heavy" computation inside the renderer this could really affect performance.

Thanks for your help!

@taauntik taauntik added premium forum Issues from forum performance OEM OEM customer enhancement Functionality improvement labels Nov 16, 2023
@matsbryntse matsbryntse added high-priority Urgent to have fixed and removed enhancement Functionality improvement labels Nov 16, 2023
@isglass isglass added bug Something isn't working ready for review Issue is fixed, the pull request is being reviewed labels Nov 17, 2023
@isglass
Copy link
Contributor

isglass commented Nov 17, 2023

PR better optimizes resizing when using lockLayout. When not using it, it currently has to pass through the normal rendering pipe in case the resize leads to a row height change.

@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Nov 17, 2023
@isglass isglass added this to the 5.6.2 milestone Nov 17, 2023
@isglass isglass closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer performance premium resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants