Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getAssignmentsForEvent param type inside AssigmentStore #7920

Closed
marciogurka opened this issue Nov 27, 2023 · 1 comment
Closed

Fix getAssignmentsForEvent param type inside AssigmentStore #7920

marciogurka opened this issue Nov 27, 2023 · 1 comment
Assignees
@kronaemmanuel
Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer resolved Fixed but not yet released (available in the nightly builds) typescript
Milestone
5.6.7

Comments

@marciogurka
Copy link

Forum post

The function available here https://bryntum.com/products/schedulerpro/docs/api/Scheduler/data/mixin/AssignmentStoreMixin#function-getAssignmentsForEvent

has a different parameter type compared to here https://bryntum.com/products/schedulerpro/docs/api/Scheduler/data/mixin/EventStoreMixin#function-getAssignmentsForEvent

Screenshot 2023-11-27 at 14 07 23 Screenshot 2023-11-27 at 14 08 10
@marciogurka marciogurka added bug Something isn't working forum Issues from forum typescript OEM OEM customer labels Nov 27, 2023
@isglass isglass added the high-priority Urgent to have fixed label Jan 24, 2024
@isglass
Copy link
Contributor

isglass commented Jan 24, 2024

Docs for EventStoreMixin are incorrect, it only accepts records, not ids (string / number)

@kronaemmanuel kronaemmanuel self-assigned this Jan 24, 2024
@kronaemmanuel kronaemmanuel added the ready for review Issue is fixed, the pull request is being reviewed label Jan 24, 2024
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Feb 1, 2024
@SergeyMaltsev SergeyMaltsev added this to the 5.6.7 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kronaemmanuel kronaemmanuel

Labels
bug Something isn't working forum Issues from forum high-priority Urgent to have fixed OEM OEM customer resolved Fixed but not yet released (available in the nightly builds) typescript
Projects
None yet
Milestone
5.6.7
Development

No branches or pull requests
4 participants
@isglass @marciogurka @kronaemmanuel @SergeyMaltsev