Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to start/end of the dependent tasks are ignored which does not allow it to pass the filter #7994

Closed
bmblb opened this issue Dec 5, 2023 · 1 comment
Assignees
Labels
bug Something isn't working high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@bmblb
Copy link

bmblb commented Dec 5, 2023

Reproducible on advanced demo:

  1. make a FS dependency from 1.1.4 to 1.1.3
  2. commit dependency by calling gantt.project.acceptChanges()
  3. change 1.1.4 duration to 2 days
  4. store project change to a variable c = gantt.project.changes
  5. undo the change
  6. set filter to a start date column after 01/16/2019. note 1.1.3 and 1.1.4 disappear (expected)
  7. now apply saved change: gantt.project.applyProjectChanges(c). 1.1.3 should become visible, but it does not
  8. now move 1.1.3 itself by setting a constraint: gantt.project.applyProjectChanges({ tasks : { updated : [{ id : 13, constraintDate : '2019-01-17', constraintType : 'startnoearlierthan', startDate : '2019-01-17' }] } }). note 1.1.3 becomes visible

Reason for this is that 1.1.3 was moved ahead by its predecessor and thus got only startDate and endDate fields in the changeset. However, those fields are stripped by applyProjectChanges method. Probably because applying startDate as part of changeset will set a constraint on a record.

Again, as with #7801 we are looking at a problem where we cannot safely feed data to an engine, because engine treats data as user input always and will attempt to run extra validation logic (put constraint, recalculate duration, etc).

@bmblb bmblb added bug Something isn't working large-account Reported by large customer OEM OEM customer labels Dec 5, 2023
@matsbryntse matsbryntse added the high-priority Urgent to have fixed label Dec 12, 2023
@arcady-zherdev
Copy link

arcady-zherdev commented Dec 15, 2023

because engine treats data as user input always and will attempt to run extra validation logic (put constraint, recalculate duration, etc).

The Engine does not set constraints when applying remote changes.

@emilschutte emilschutte self-assigned this Dec 15, 2023
@isglass isglass added the resolved Fixed but not yet released (available in the nightly builds) label Jan 10, 2024
@isglass isglass added this to the 5.6.6 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority Urgent to have fixed large-account Reported by large customer OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

5 participants