Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggleSidebar item has not consistent naming #8145

Closed
chuckn0rris opened this issue Dec 29, 2023 · 1 comment
Closed

toggleSidebar item has not consistent naming #8145

chuckn0rris opened this issue Dec 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@chuckn0rris
Copy link

Forum post

see docs:
https://bryntum.com/products/calendar/docs/api/Calendar/view/Calendar#config-tbar

we have toggleSidebar name, but in the code we use toggleSideBar. SOo, docs or code should be fixed.

@chuckn0rris chuckn0rris added bug Something isn't working forum Issues from forum large-account Reported by large customer labels Dec 29, 2023
@ExtAnimal
Copy link

ExtAnimal commented Dec 29, 2023

"Sidebar" is a noun and a class name, so the item name is incorrect and should be changed.

The docs use the correct name.

We can change the name in the configuration, but add

    changeTbar(tbar) {
        if (tbar.toggleSideBar) {
            tbar.toggleSidebar = tbar.toggleSideBar;
            delete tbar.toggleSideBar;
        }
        return super.changeTbar(...arguments);
    }

for backwards compatibility until 7.0

@ExtAnimal ExtAnimal self-assigned this Dec 30, 2023
@ExtAnimal ExtAnimal added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Dec 30, 2023
@ExtAnimal ExtAnimal added this to the 5.6.5 milestone Dec 30, 2023
@ExtAnimal ExtAnimal added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

2 participants