Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animated region collapse polish #8259

Closed
3 tasks
isglass opened this issue Jan 15, 2024 · 1 comment
Closed
3 tasks

Animated region collapse polish #8259

isglass opened this issue Jan 15, 2024 · 1 comment
Assignees
@kronaemmanuel
Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Milestone
5.6.9

Comments

@isglass
Copy link
Contributor

isglass commented Jan 15, 2024 •
edited by kronaemmanuel

  • Time axis does not animate expand:

no-anim

  • Events jump into place after collapsing locked region:

rough

Both can be seen on http://lh/bryntum-suite/SchedulerPro/examples/nested-events/ on master

  • Fix embedded-chart.t.js test on Firefox, If we collapse and then expand the subgrid a few times, it loses it's original width (probably due to timing issue)
@isglass isglass added bug Something isn't working high-priority Urgent to have fixed labels Jan 15, 2024
@isglass
Copy link
Contributor Author

isglass commented Jan 15, 2024 •
edited

  • Related: runWithTransition should not need a timeout fallback, except for in Saleseforce. Move that to an override

  • Missing * in docs

image

@matsbryntse matsbryntse added this to the 6.0.0 milestone Jan 15, 2024
@kronaemmanuel kronaemmanuel mentioned this issue Feb 16, 2024
Closed
@kronaemmanuel kronaemmanuel added ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Mar 20, 2024
@kronaemmanuel kronaemmanuel modified the milestones: 6.0.0, 6.0.0-alpha-2 Mar 22, 2024
@kronaemmanuel kronaemmanuel mentioned this issue Mar 22, 2024
Closed
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed BLOCKING labels Mar 26, 2024
@isglass isglass modified the milestones: 6.0.0-alpha-2, 5.6.9 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kronaemmanuel kronaemmanuel

Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Milestone
5.6.9
Development

No branches or pull requests
3 participants
@matsbryntse @isglass @kronaemmanuel