Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel loses height immediately when collapsing code editor #8381

Closed
matsbryntse opened this issue Jan 29, 2024 · 2 comments
Closed

Panel loses height immediately when collapsing code editor #8381

matsbryntse opened this issue Jan 29, 2024 · 2 comments
Assignees
Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@matsbryntse
Copy link
Member

matsbryntse commented Jan 29, 2024

Check at 4s in the video upon collapse icon click.

collapse.mov

image -> click -> image

@matsbryntse matsbryntse added the bug Something isn't working label Jan 29, 2024
@dongryphon
Copy link

dongryphon commented Jan 31, 2024

I added some screenshots from the video. The issue is that no tool remains in the header and that causes it to shrink in height. I will see about keeping the download or re-expand tool in both modes.

@dongryphon
Copy link

Seems that there are some code and style overrides beyond basic panel collapse. The height of the collapsed header is correct in some themes (at least Stockholm) but is wrong in Material. Leaving any tool in the header corrects this.

@dongryphon dongryphon added the ready for review Issue is fixed, the pull request is being reviewed label Jan 31, 2024
@matsbryntse matsbryntse added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jan 31, 2024
@matsbryntse matsbryntse added this to the 5.6.7 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

2 participants