Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting empty name for new task when created using addTaskAbove/addTaskBelow #8408

Closed
ghulamghousdev opened this issue Jan 31, 2024 · 0 comments
Assignees
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@ghulamghousdev
Copy link
Member

Forum post

When i try to default the name as null, its not working, currently when we add a row the Name is defaulted as New task 2, New task 3.. and so on.


class Task extends TaskModel {
  static get fields() {
    return [
      { name: 'weight', type: 'number' },
      { name: 'name', type: 'string' },
    ]
  }

  get name () {
    return super.data['task_number']
  }

  set name(value) {
    super.set('task_number', value);
  }
}



const newTaskDefaults = {
    project_id: parseInt(projectId),
    row_type: "T",
    name: "",
    task_name: "",
    task_long_name: "",
    task_status: "NOT_STARTED",
    ....
  }


by adding, name: "" in new task default, it is still adding "New Task 1" as task_number/name

@ghulamghousdev ghulamghousdev added bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer labels Jan 31, 2024
@ghulamghousdev ghulamghousdev self-assigned this Jan 31, 2024
@ghulamghousdev ghulamghousdev changed the title Allow setting empty name for new task using menu Allow setting empty name for new task when created using addTaskAbove/addTaskBelow Feb 1, 2024
@ghulamghousdev ghulamghousdev added the ready for review Issue is fixed, the pull request is being reviewed label Feb 1, 2024
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Feb 1, 2024
@isglass isglass added this to the 5.6.7 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

2 participants