Calendar intervals not applied properly in case of using specific rules

[chuckn0rris]

Forum post

import { Toolbar, Toast, DateHelper, CSSHelper, Column, ColumnStore, Combo, TaskModel, Gantt,StringHelper } from '../../build/gantt.module.js?474872';
import shared from '../_shared/shared.module.js?474872';


const gantt = new Gantt({
    appendTo          : 'container',
    dependencyIdField : 'sequenceNumber',
    rowHeight         : 45,
    tickSize          : 45,
    barMargin         : 8,

    columns : [
        { type : 'name', width : 250 },
        { type : 'startdate', width : 100 },
        { type : 'enddate', width : 100 },
        { type : 'duration', width : 80 },
        { type : 'effort', width : 80 }
    ],

    // Custom task content, display task name on child tasks
    taskRenderer({ taskRecord }) {
        if (taskRecord.isLeaf && !taskRecord.isMilestone) {
            return StringHelper.encodeHtml(taskRecord.name);
        }
    }
});

const project = gantt.project.inlineData;

project.eventsData = [
    {
        id        : 1,
        name      : 'Task 1',
        startDate : '2021-01-01T08:00:00',
        endDate   : '2021-01-04T16:00:00',
        duration  : 5
    },
    {
        id        : 2,
        name      : 'Task 2',
        startDate : '2021-01-01T08:00:00',
        endDate   : '2021-01-04T16:00:00',
        duration  : 5
    }
];

project.calendarsData = [
    {
        id        : 123456,
        name      : 'My Calendar',
        intervals : [
            {
                recurrentStartDate : 'at 08:00',
                recurrentEndDate   : 'at 16:00',
                isWorking          : true
            },
            {
                recurrentStartDate : 'on Sat at 00:00',
                recurrentEndDate   : 'on Mon at 00:00',
                isWorking          : false
            }
        ],
        unspecifiedTimeIsWorking : false
    }
];

gantt.project.inlineData = project;

gantt.project.hoursPerDay = 8;
gantt.project.calendar = 123456;

See non working intervals applied to only few weekends.

[canonic-epicure]

Seems to be fine for me, perhaps fixed in the latest release?

[canonic-epicure]

Ah, reproducible with the code from the 1st post, I'll update the snippet in the ticket.

[canonic-epicure]

So it seems to be dependent on the order of the intervals, works fine if weekend is defined first:

            {
                recurrentStartDate : 'on Sat at 00:00',
                recurrentEndDate   : 'on Mon at 00:00',
                isWorking          : false
            },
            {
                recurrentStartDate : 'at 08:00',
                recurrentEndDate   : 'at 16:00',
                isWorking          : true
            },

I'll be checking why this matters.

[canonic-epicure]

So the issue is caused by the fact, that the recurrent intervals intersect:

        intervals : [
            {
                recurrentStartDate : 'at 08:00',
                recurrentEndDate   : 'at 16:00',
                isWorking          : true
            },
            {
                recurrentStartDate : 'on Sat at 00:00',
                recurrentEndDate   : 'on Mon at 00:00',
                isWorking          : false
            }
        ]

Here the timespan 08:00-16:00 is defined both in the 1st recurrent interval and the 2nd, and also the isWorking flag is different in them. Currently, in such cases, it is undefined behavior, which interval will be picked. To define which interval "wins" one can use the priority field (currently undocumented, interval with higher priority "wins"):

        intervals : [
            {
                recurrentStartDate : 'at 08:00',
                recurrentEndDate   : 'at 16:00',
                priority : 1, 
                isWorking          : true
            },
            {
                recurrentStartDate : 'on Sat at 00:00',
                recurrentEndDate   : 'on Mon at 00:00',
                priority : 2, 
                isWorking          : false
            }
        ]

Or, (recommended), define the intervals so that they don't intersect - for example limit the 08-16 rule by weekdays only:

   intervals : [
         {
                recurrentStartDate : 'on Mon, Tue, Wed, Thu, Fri at 08:00',
                recurrentEndDate   : 'on Mon, Tue, Wed, Thu, Fri at 16:00',
                isWorking          : true
            },
            {
                recurrentStartDate : 'on Sat at 00:00',
                recurrentEndDate   : 'on Mon at 00:00',
                isWorking          : false
            }
        ],

[canonic-epicure]

I guess the resolution for this ticket will be updating the docs about the behavior of intersecting recurrent intervals and documenting the priority field on them.

[canonic-epicure]

Or, we can prioritize the interval with the bigger index in the store.

[canonic-epicure]

After conversation with Arcady we decided to do both.