DateHelper startOf week method does not return correct output for Sunday

[ghulamghousdev]

Forum post

Hello team, please see an example:
Core.helper.DateHelper#function-startOf-static
Just run in console of the docs

oneWeek = [
    { day: 'Monday', date: new Date(2024, 2, 18) },
    { day: 'Tuesday', date: new Date(2024, 2, 19) },
    { day: 'Wednesday', date: new Date(2024, 2, 20) },
    { day: 'Thursday', date: new Date(2024, 2, 21) },
    { day: 'Friday', date: new Date(2024, 2, 22) },
    { day: 'Saturday', date: new Date(2024, 2, 23) },
    { day: 'Sunday', date: new Date(2024, 2, 24) }
]

firstDay = 1

oneWeek.map(item => {
    return DateHelper.startOf(item.date, 'week', true, firstDay)
})

I expect start of week for all days above is Monday, the March 18th. But for Sunday it returns the March 25th which is Monday next week.

[kronaemmanuel]

Untested solution....problem is in DateHelper.startOf in switch statement when it calculates delta, it should be:

            case 'week': {
                const delta = (date.getDay() < weekStartDay) ? date.getDay() - weekStartDay + 7 : date.getDay() - weekStartDay;
                date.setDate(date.getDate() - delta);
                date.setHours(0, 0, 0, 0);
                return date;
            }

Seems to solve:

Idk about other cases tho. Will have to check.