Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal masks for multiple popups are not working #8880

Closed
MPulxeR opened this issue Mar 25, 2024 · 0 comments
Closed

Modal masks for multiple popups are not working #8880

MPulxeR opened this issue Mar 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@MPulxeR
Copy link

MPulxeR commented Mar 25, 2024

When having multiple popups (Dialogs), the modal mask is "only" rendered correct on the first popup. When the second popup is opened ... the modal mask is not shown ... e.g.:

image

That leads to the problem, that the second popup is either not directly shown (without focus) ... or, it will be autoClosed or loosing its focus once the first popup is clicked.

Looking at the DOM, only one modal mask is rendered. However, expectation is each modal popup has its own modal mask.

Here is an example for CodePen.io:


import * as Module from 'https://bryntum.com/products/grid/build/grid.module.js';
Object.assign(window, Module);

new Button({
    appendTo : document.body,
    cls      : 'b-raised',
    text     : 'Show popup',
    onClick  : function(e) {
        let popup = new Popup({
            autoShow: false,
            autoClose: false,
            centered: true,
            modal: true,
            width: '60%',
            height: '60%',
            items: [new Button({
              text: 'open another modal popup',
              onClick: function(e) {
                var internalPopup = new Popup({
                  width: '40%',
                  height: '40%',
                  header: 'internal modal popup',
                  centered: true,
                  modal: true,
                  autoShow: false,
                  autoClose: false
                });
                internalPopup.show();
                internalPopup.focus();
              }
            })
            ]
        });
        popup.show();
    }
});

@matsbryntse matsbryntse added bug Something isn't working regression Worked previously, now broken labels Mar 25, 2024
@ExtAnimal ExtAnimal changed the title [BUG] Modal masks for multiple popups are not working ... Modal masks for multiple popups are not working Mar 25, 2024
@ExtAnimal ExtAnimal added the ready for review Issue is fixed, the pull request is being reviewed label Mar 25, 2024
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Mar 26, 2024
@isglass isglass added this to the 5.6.9 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants