-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide a way to run raw shell commands post install. #103
Comments
even with So I think it would be best to add a new option: and have code like:
|
So do you want a non-chroot and chroot version of this post install shell command runner? Also giving the shell commands the chroot location in an environment variable seems like the best way to go in the non-chroot case, is that fitting with your use case? |
I think the chroot version is more helpfull but having the none chroot version would be a nice extra. agree passing in the chroot path as an env var is the way to go. If you do go to add these. Perhaps also add a PreBashCmds. This would allow some way to shim in support for odd things like perhaps raid drivers. |
I have code working for the both chroot and non-chroot post handlers. I'm curious when exactly you'd like the pre handlers to be run though. I'd guess you'd get the most flexability from having them run directly after template validation but that could be too early. From my perspective having commands run after validation and before any actual processing would be enough to support raid. Any more details for your use case would be handy here. |
I didn't have a true use case for the pre command. debian has something like this |
@steverweber #105 created in response to this issue. |
validate_postnonchroot_template
is limiting what can run to only script files that can be found on the filesystem. this is painful when trying to performing some custom commands after a pxe boot install. I'mforced to change the initrd to hack in some script.. would be much cleaner and direct if the shell commands could be included in the
ister.json
.it would be helpful if
validate_postnonchroot_template
did no checks at all or another option likePostNonChrootRaw
was added.running raw commands would be nice.
The text was updated successfully, but these errors were encountered: