Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of swupd progress #108

Closed
bryteise opened this issue Oct 3, 2017 · 4 comments
Closed

Improve display of swupd progress #108

bryteise opened this issue Oct 3, 2017 · 4 comments

Comments

@bryteise
Copy link
Owner

bryteise commented Oct 3, 2017

Swupd's output has been updated since the current progress display with added. Adapt the progress to better display what is happening in swupd.

@bryteise
Copy link
Owner Author

bryteise commented Oct 3, 2017

There is a proposal to update swupd to output differently when running verify --install that could improve this without needing to modify ister. Another potential solution would be to have swupd output to a log and make the gui read that file for swupd progress updates.

@dedekind
Copy link
Contributor

Did you notice that after one of my pull requests where the 'run_command()' function was reqorked' the swupd progress displaying has also been improved. Not that it is ideal, but it now does actually follow the progress somewhat.

The core of the problem with following is 'swupd' printing those dots without newline character. If that is imporved - ister's swupd following will automatically improve too.

Here is what is going on now.

  1. swupd prints some progres info to stderr in a reasonable way. Short lines followed by newline.
  2. In parallel swupd prints lots of dots to stdout.

When someone runs swupd from a terminal, stdout and stderr kind of get interleaved and end result looks OK.

But wen we run swupd from ister - we buffer collect full lines and print them. And the end result is that dots are delayed and the output is not so nice. We do not have to buffer, but the output looks very very ugly in this case.

IOW, I highly suspect this issue is not really an issue anymore.

@bryteise
Copy link
Owner Author

Ah indeed, thanks for bringing that to my attention, I'll try making a release today and see how it goes.

@bryteise
Copy link
Owner Author

So it looks like this is in pretty good shape aside as far as the ister side of things can help anyway. Calling this good then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants