-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some feedback #2
Comments
Hey @saschatimme, thanks for taking the time to write this
|
Timings for
My workflow is currently js for dev and possibly native for release (since Jest for js is just awesome).
I think you would be more flexible than now. And I think waiting for namespaces is the right choice. |
Just to follow up. number 2 and 3 have been fixed in master. I will check number 1 today and number 4 is related to @TheSpyder 's feedback in #3. I'm still thinking about it but it might be that I allow you to specific specific dirs for specific targets.
|
Sounds reasonable. I'd suggest allowing the rename up front, defaults are great but everyone has their own opinions about project structure. For example at my workplace we tend to group folders by code type, so right now I have
src/test/re is 100% native, src/main/re is 99% pure reason and 1% JS specific (segregated into a folder). |
All of this is fixed in master :) |
I converted a mediumish (around 5k loc) to bsb-native yested and it was quite smooth! My 360 unit tests now need 1200 ms in js, 400ms with bytecode and 50ms with native 馃挴.
Here are a couple of things I think could be improved:
bsc
seem different. Especially I got warning 40 which was quite annoying. I added["-no-alias-deps", "-color", "always", "-w", "-40+6+7+27+32..39+44+45"]
and everything was fine again.entries
will be build.bsb
to specify which kind, .i.e. js, bytecode or native, will be build? Currently it seems that if there is an entry present inentries
this will determine the kind. So if I want to build normally for js and only sometimes for native, I have to comment things in/out in the bsconfig.npm link
magic to have everything still in the same repo. (I can elaborate if you are curious about the details). I think a better solution would be to have the possibility to set on a per directory basis which kinds are allowed.This would also reduce the amount of restructuring necessary for a dual build and eliminate the need to extract some sort of interface (like in your ReasonGl thing).
The text was updated successfully, but these errors were encountered: