Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💻 Update external API links #249

Closed
bsantosh909 opened this issue Oct 14, 2022 · 2 comments · Fixed by #326
Closed

💻 Update external API links #249

bsantosh909 opened this issue Oct 14, 2022 · 2 comments · Fixed by #326
Assignees
@FroostyCodes
Labels
Enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@bsantosh909
Copy link
Owner

Is your feature request related to a problem? Please describe.

The external links can be improved a bit.

Describe the solution you'd like

It would be great to add the follow to the external API links:

Describe alternatives you've considered

N/A

Additional context

In order to add the ref to the links we can use template string from the href prop and add ?ref=apiParty in the prop itself
@bsantosh909 bsantosh909 added Enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 14, 2022
@abhijeet007rocks8 abhijeet007rocks8 mentioned this issue Oct 17, 2022
Closed
@bsantosh909 bsantosh909 changed the title Update external API links 💻 Update external API links Oct 24, 2022
@FroostyCodes
Copy link
Contributor

Hi @TheLearneer
Can I work on this issue?

@bsantosh909
Copy link
Owner Author

Sure @FroostyCodes
Go ahead with it 💪

@FroostyCodes FroostyCodes mentioned this issue Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FroostyCodes FroostyCodes

Labels
Enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Update external links to have ref value
2 participants
@bsantosh909 @FroostyCodes