Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose entire container input and/or container image #16

Closed
nitrocode opened this issue Jan 1, 2023 · 1 comment · Fixed by #20
Closed

Expose entire container input and/or container image #16

nitrocode opened this issue Jan 1, 2023 · 1 comment · Fixed by #20

Comments

@nitrocode
Copy link
Member

nitrocode commented Jan 1, 2023

Its limiting to only support a conditional for the container image

It would be good to expose the entire container input or at least the full container image.

For example, what if i wanted to use a custom image or a custom tag?

https://github.com/bschaatsbergen/terraform-gcp-atlantis/blob/474dbae438ca7005f03a1de3b47f962c694e8cb1/atlantis.tf#L9

You may want to expose more inputs to the upstream module as well

You can also avoid having to put in additional logic for the dev tag #3.

@bschaatsbergen
Copy link
Contributor

For the initial release of the module we can start with exposing the full container image, I agree that's a good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants