Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add firewall rule and open listen port on os #33

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix: add firewall rule and open listen port on os #33

merged 4 commits into from
Jan 5, 2023

Conversation

mvanholsteijn
Copy link
Contributor

No description provided.

@bschaatsbergen
Copy link
Contributor

The LB firewall is already present: https://github.com/bschaatsbergen/terraform-gce-atlantis/blob/4193c79dc41ea86424345c4d7aa846c2c4cefbe8/main.tf#L305

bschaatsbergen
bschaatsbergen reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 - I'm quickly testing the startup script changes before

@bschaatsbergen
Copy link
Contributor

Thanks for your contribution 🎉 👏

@bschaatsbergen bschaatsbergen merged commit 14c7d63 into runatlantis:main Jan 5, 2023
@bschaatsbergen bschaatsbergen mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschaatsbergen bschaatsbergen bschaatsbergen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvanholsteijn @bschaatsbergen