Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import l10n if the l10n file is in the root directory of the project's included files #21

Closed
shichen85 opened this issue Dec 4, 2020 · 0 comments · Fixed by #22
Assignees
Labels
🔥 bug Something isn't working

Comments

@shichen85
Copy link
Member

const directoryRelative = `datafiles/${paths.asPosixPath(subdirectory||'NEW')}`;

When there is no subdirectory, directoryRelative is set to datafiles/NEW, but there might be a file at datafiles. This will trigger the error because matchingFile.directoryRelative != directoryRelative, which effectively causes any file at the root level of the project's included files to always trigger conflicts.

I think we should just stop checking the subdirectory mismatch and overwrite the destination file. The change will show up in the git history anyways so the end-user can discern whether this is a mistake that requires renaming or that it is fine.

@shichen85 shichen85 added the 🔥 bug Something isn't working label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants