Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comma-separated patterns for folder filters when merging #37

Closed
adam-coster opened this issue Dec 21, 2021 · 0 comments
Closed

Allow comma-separated patterns for folder filters when merging #37

adam-coster opened this issue Dec 21, 2021 · 0 comments
Assignees
Labels
✨ feature New feature or request

Comments

@adam-coster
Copy link
Member

It's more likely that someone will want to list a set of folders, than that they'd want to provide a regex, when filtering on merge.

For example, if a user wanted to import two modules, "TestSuite" and "MyRadModule", they'd currently have to use:

stitch merge --if-folder-matches "(TestSuite|MyRadModule)"

Since most people are not very familiar with regex, it would make more sense to have it not behave has a regex pattern by default, and to also allow comma-separated values. For example:

stitch merge --if-folder-matches TestSuite,MyRadModule

If the user wants to use a regex, we can either:

  • Switch modes when a non-varname character appears (e.g. if []()$^*+ appear in the filter string).
  • Have a separate option flag for regex-based matching.
@adam-coster adam-coster added the ✨ feature New feature or request label Dec 21, 2021
@adam-coster adam-coster self-assigned this Dec 21, 2021
@adam-coster adam-coster closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant