Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets to the token provider #59

Closed
3 tasks done
adam-coster opened this issue May 3, 2023 · 0 comments
Closed
3 tasks done

Add assets to the token provider #59

adam-coster opened this issue May 3, 2023 · 0 comments
Assignees
Labels
✨ feature New feature or request ⌨️ vscode The Stitch extension for VSCode

Comments

@adam-coster
Copy link
Member

adam-coster commented May 3, 2023

Using Ctrl+P to find GameMaker stuff is a little unpleasant, since we usually don't care about YY files but also filenames in general aren't very useful (e.g. we often want to find a function defined in a script, but don't really care about the script).

The VSCode extension implements a token provider for globals (via Ctrl+T), but this doesn't include assets since they aren't defined in code. This makes it really annoying to quickly open up an object, for example.

To resolve this, we need to add assets to the token provider:

  • For objects, add one entry per event where the location is the event's GML file
  • For scripts, add one entry to the start of the GML file
  • For everything else, add one entry to the YY file
@adam-coster adam-coster added this to the vscode-mvp milestone May 3, 2023
@adam-coster adam-coster self-assigned this May 3, 2023
@adam-coster adam-coster added ✨ feature New feature or request ⌨️ vscode The Stitch extension for VSCode labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request ⌨️ vscode The Stitch extension for VSCode
Projects
None yet
Development

No branches or pull requests

1 participant