Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded port 80 by $_SERVER['SERVER_PORT'] #25

Closed
wants to merge 1 commit into from

Conversation

Alkarex
Copy link
Contributor

@Alkarex Alkarex commented Oct 15, 2013

In order for the demo to work out of the box on a test server (often on a port different from 80 such as 8080), here is a suggestion to default to $_SERVER['SERVER_PORT'] instead of a hard-coded port 80.
Of course, the explicit configuration in parameters.json still has precedence.

In order for the demo to work out of the box on a test server (often on a port different from 80 such as 8080), here is a suggestion to default to $_SERVER['SERVER_PORT'] instead of a hard-coded port 80.
Of course, the explicit configuration in parameters.json still has precedence.
@bshaffer bshaffer closed this in 319e741 Oct 15, 2013
@bshaffer
Copy link
Owner

@Alkarex thank you so much for this change!

I have made the change slightly different, as to avoid changing the Curl class itself, I pass in the port to the constructor in index.php, and added the Curl object to the container (see a156e20).

Will you test this change and see if it meets your requirements?

@Alkarex
Copy link
Contributor Author

Alkarex commented Oct 15, 2013

Thanks for the fast response!
Yes, it works well on a test server using port 8080 after the patch 319e741 and it is nicer than the previous approach 👍

@Alkarex Alkarex deleted the patch-1 branch October 15, 2013 15:45
@bshaffer
Copy link
Owner

Teamwork! Glad to hear it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants