Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT bearer tokens client authentication #27

Closed
F21 opened this issue Jan 16, 2013 · 8 comments
Closed

JWT bearer tokens client authentication #27

F21 opened this issue Jan 16, 2013 · 8 comments

Comments

@F21
Copy link
Contributor

F21 commented Jan 16, 2013

In PR #25, we have support for JWT as Authorization Grants

Now, we need support for JWT as Client Authentication

@F21
Copy link
Contributor Author

F21 commented Jan 17, 2013

Before I start on this, what do you think about implementing the plugin architecture as mentioned earlier before doing this?

@bshaffer
Copy link
Owner

I don't think it will be happening any time soon. Code away!

@bshaffer
Copy link
Owner

One thing I wouldn't mind seeing is an interface for the ExtensionGrantType, so JWT and any other types can extend those.

@F21
Copy link
Contributor Author

F21 commented Apr 2, 2013

@bshaffer Just revisiting this (its been a while!).

Latest spec for JWT is here.

For JWT client authentication, it is basically piggy backing on the authorization_code grant type. So we can either put the code for that into the AuthorizationCode grant type or perhaps provide some modular approach.

I personally favour a more modular approach, but am unsure how this can be done. Any ideas 😄 ?

@bshaffer
Copy link
Owner

bshaffer commented Apr 2, 2013

Well, I DO like the word "modular" :)

As long as it implements a common interface I am cool with either approach... extending a base class or duplicating the code. Our "built in" JWT client assertion could just extend the AuthorizationCode grant type wholesale.

Honestly, I'd have to wrap my brain around the problem a little more. I will definitely look into it, and offer feedback to any code you submit!

@bshaffer
Copy link
Owner

bshaffer commented May 9, 2013

I may be missing something, but I believe this is already done. JWTBearer now implements ClientAssertionTypeInterface. This means, if we want to use it for client assertions, we just need to pass it in to the TokenController object when we create it.

There is still the issue that there is no way to pass this in to the Server class. However, if we add this, we should be good to go.

@F21
Copy link
Contributor Author

F21 commented May 9, 2013

@bshaffer I will have a look at it over the next few days (pretty busy atm) and get back to you 😄

@F21
Copy link
Contributor Author

F21 commented May 13, 2013

Thanks to @bshaffer, ClientAssertionTypeInterface is implemented, client authentication is now supported. Now, we just need to find a way to pass this to the Server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants