Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough code missing the 'password' grant_type #459

Closed
jessp01 opened this issue Sep 16, 2014 · 2 comments
Closed

Walkthrough code missing the 'password' grant_type #459

jessp01 opened this issue Sep 16, 2014 · 2 comments

Comments

@jessp01
Copy link

jessp01 commented Sep 16, 2014

Hello,

Great work on this, very educational and helpful. Many thanks.

Here:
http://bshaffer.github.io/oauth2-server-php-docs/cookbook/

The server.php code should probably also include:
// Add the "password" grant type (this is where the oauth magic happens)
$server->addGrantType(new OAuth2\GrantType\UserCredentials($storage));

This is also important for people trying the demo app later.

Thanks,

@bshaffer
Copy link
Owner

The UserCredentials grant type is not where the OAuth magic happens. The magic happens with Authorization Code and Implicit grant types, where the flow is 3-legged.

We have an example of UserCredentials grant type here, and there is another example in the demo app, so I don't see the usefulness in adding the line of code above.

@bshaffer
Copy link
Owner

closing in favor of bshaffer/oauth2-server-php-docs#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants