Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2_Server->getClientCredentials() problem #85

Closed
trickleup opened this issue Mar 15, 2013 · 2 comments
Closed

OAuth2_Server->getClientCredentials() problem #85

trickleup opened this issue Mar 15, 2013 · 2 comments

Comments

@trickleup
Copy link
Contributor

At the token endpoint, using the client credentials grant flow, I'm calling the OAuth2_Server function getClientCredentials(), that defers to the GrantController and in turn calls getClientCredentials() on the grant controller. Problem is that the grant controller doesn't implement getClientCredentials(). It seems the logic to extract the credentials is in OAuth2_ClientAssertionType_HttpBasic, and I can just instantiate that class and get the credentials that way - but that doesn't seem like best practice. Any advice?

@bshaffer
Copy link
Owner

This seems fine to me. It is unfortunate you have to pass in a storage object for something that doesn't actually require storage, but other than that small annoyance, this will work perfectly fine.

@trickleup
Copy link
Contributor Author

Ok, great. Thanks for replying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants