Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test error with Go 1.14beta1 #58

Closed
eclipseo opened this issue Jan 29, 2020 · 5 comments
Closed

Test error with Go 1.14beta1 #58

eclipseo opened this issue Jan 29, 2020 · 5 comments

Comments

@eclipseo
Copy link

Fedora Rawhide, with Go 1.14beta1, logrus-logstash-hook 0.4.1

Testing    in: /builddir/build/BUILD/logrus-logstash-hook-0.4.1/_build/src
         PATH: /builddir/build/BUILD/logrus-logstash-hook-0.4.1/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/logrus-logstash-hook-0.4.1/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/bshuster-repo/logrus-logstash-hook/version=0.4.1 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/bshuster-repo/logrus-logstash-hook
github.com/bshuster-repo/logrus-logstash-hook
--- FAIL: TestLogstashFormatter (0.00s)
    logstash_formatter_test.go:58: expected data[error] to be 'Get http://example.com: The error' but got 'Get "http://example.com": The error'
FAIL

Seem like the formatting changed slightly to include quotes.

@eclipseo
Copy link
Author

@boaz0
Copy link
Member

boaz0 commented Feb 27, 2020

Hey @eclipseo 👋 It seems like an easy fix, would you mind working on it?
If it's too much work for you, I will try to push a fix in the next days.

Sorry for the late response and thanks for looking into it.

@boaz0
Copy link
Member

boaz0 commented Mar 18, 2020

@eclipseo - I looked at it and I decided that version 0.4.1 is going to support only old versions of Go (up to Go 1.12).
I am releasing a new release (1.0) that supports new versions of Go.

Please review this and close it if it's OK. Thanks.

@eclipseo
Copy link
Author

Hey sorry for the delay. I've built 1.0.0 with Go 1.15 beta 1 and everything works fine.

@boaz0
Copy link
Member

boaz0 commented Jul 25, 2020

Thanks @eclipseo for the update.
I am sorry for taking me too long fixing it. I hope next time I will do a better and faster job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants