Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.1 #16

Closed
bananu7 opened this issue Jan 27, 2015 · 8 comments · Fixed by #18
Closed

Update to 3.1 #16

bananu7 opened this issue Jan 27, 2015 · 8 comments · Fixed by #18

Comments

@bananu7
Copy link

bananu7 commented Jan 27, 2015

No description provided.

@schell
Copy link
Collaborator

schell commented Jan 27, 2015

This is in the works 👍

@bananu7
Copy link
Author

bananu7 commented Jan 28, 2015

@schell Oh well good to know. I've spent a few hours diffing the sources and outlining the plan for update. If you need any help, let me know.

I've noticed that headers weren't updated for 3.0.4 though, I'll make another issue for that. (#17)

@schell
Copy link
Collaborator

schell commented Jan 28, 2015

I would love help! Thank you! Any and all contributions are welcome. What platform are you on?

@bananu7
Copy link
Author

bananu7 commented Jan 29, 2015

I'm on Windows 7 and 8.1, both running x64 Platform.

I didn't get too far. I diffed the sources, which made me discover the header discrepancy. Otherwise, 3.1 moves a lot of files around, and some files appear to disappear; I'm not sure if their functionality is gone or simply moved.

That being said, the library built for me, but some tests fail (notably with window focus and sizing). This is the case in both the bindings and the actual GLFW-b (so I suspect the bindings are the real culprit). I can create another issue for the failing tests once I'll create a reliable reproduction plan.

@lukexi
Copy link
Contributor

lukexi commented Feb 12, 2015

Yo dudes,

I updated these to 3.1 for OS X here: https://github.com/lukexi/bindings-GLFW/
(I was hitting a crash with multi-monitors/Rift in 3.0.3/3.0.4 so I needed to do it)

I was able to build GLFW-b on top of that and it worked great (and fixed the crash too : D )

I made what looked like the right tweaks for Windows and Linux but I haven't tested them yet, so you can just use it as inspiration for now if you like : ).

Cheers

@schell
Copy link
Collaborator

schell commented Feb 12, 2015

Bad ass @lukexi! Thanks! I'll start a pull request for you.

@schell
Copy link
Collaborator

schell commented Feb 12, 2015

I've opened the pull request as #18. @bananu7 - do you mind checking out @lukexi's master branch to validate that it builds on Windows?

@bananu7
Copy link
Author

bananu7 commented Feb 23, 2015

Ah sure I'll get to it ASAP. The notification/e-mail drowned somehow.

@schell schell closed this as completed in #18 Mar 6, 2015
schell added a commit that referenced this issue Mar 6, 2015
Updated to GLFW 3.1 - Fixes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants