Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alg field for encryption keys doesn't appear to give correct options #18

Closed
chadlwilson opened this issue Jan 11, 2021 · 3 comments
Closed

Comments

@chadlwilson
Copy link

chadlwilson commented Jan 11, 2021

Firstly, great little tool here! Thanks!

One observation I have is that if you choose to generate an encryption-usage key, the alg choices and generated key appears to be incorrect, and populates with JWS algs (RS256, ES256 etc)

While alg is optional in general, for encryption keys, believe these should be RSA-OAEP-256, ECDH-ES, ECDH-ES+A256KW etc per https://tools.ietf.org/html/rfc7518#section-4.1

@chadlwilson chadlwilson changed the title Alg field for encryption algs doesn't appear to give correct options Alg field for encryption keys doesn't appear to give correct options Jan 11, 2021
@jricher
Copy link
Contributor

jricher commented Jan 12, 2021

Good observation, right now the tool doesn't take into account the "use" field when making values available for the other fields, and the alg field pulls from a list of JWS values. we can look at adding that, or a pull request would be appreciated if you can!

@jricher
Copy link
Contributor

jricher commented Jan 14, 2021

I put in a fix for this and it's been pushed to the website. If there are any issues like missing or miscategorized algorithms, just file another issue or PR. Thanks!

@chadlwilson
Copy link
Author

Wow, thanks! Hadn't got around to looking at it yet 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants