Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why refactoring into SASS? #68

Closed
LockeAG opened this issue Aug 5, 2021 · 4 comments
Closed

Why refactoring into SASS? #68

LockeAG opened this issue Aug 5, 2021 · 4 comments
Labels

Comments

@LockeAG
Copy link

LockeAG commented Aug 5, 2021

I'm just reading all the new changes on starbase, and why the abrupt change from PostCss to Sass?

@bstaruk
Copy link
Owner

bstaruk commented Aug 5, 2021

Thanks for writing, @LockeAG

PostCSS has been the biggest pain point in maintaining this repo because of the number of plugins it relies on just to be viable. Sass offers everything (and more) we had in our PostCSS setup, but with about 10 less dependencies and much cleaner Webpack configs.

Basically, I figured it was time to stop swimming up stream.

@LockeAG
Copy link
Author

LockeAG commented Aug 6, 2021

I experience myself some very slow compiling and bigger file sizes with sass , but lets give it try.

I re-fork it, and also update the with @babel/eslint-parser and eslint-webpack-plugin , I hope this may help to this repo

https://github.com/LockeAG/starbase

:)

@bstaruk
Copy link
Owner

bstaruk commented Aug 6, 2021

@LockeAG Thank you for that! I didn't even realize those packages were archived/deprecated. I've swapped them in develop and they'll be included in the next release (in the next few days).

@bstaruk
Copy link
Owner

bstaruk commented Aug 8, 2021

The feedback received in this PR should be all addressed in #69

Thank you again for your help @LockeAG 🥇

@bstaruk bstaruk closed this as completed Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants