Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checkbox component #21

Closed
1 task
Tracked by #7
dstrukt opened this issue Jan 28, 2022 · 3 comments
Closed
1 task
Tracked by #7

Improve checkbox component #21

dstrukt opened this issue Jan 28, 2022 · 3 comments

Comments

@dstrukt
Copy link
Member

dstrukt commented Jan 28, 2022

  • Increase checkbox size & states

Still debating if I want the checkbox to sit vertically at the top or in the middle (like the switch component), a minor tweak we could decided upon when implementing ... but regardless.

Screen Shot 2022-03-10 at 5 35 12 PM

@dstrukt
Copy link
Member Author

dstrukt commented Mar 11, 2022

Updates

@dennisreimann
Copy link
Member

Shall we replace the box-shadow that the focused inputs currently have with the green border also?

How should this translate to dark mode?

@dstrukt
Copy link
Member Author

dstrukt commented Apr 2, 2022

Hopefully this should answer some questions .. would like to improve some of the :focused states as well, as you'll start to see in some of the mocks posted, but I'm going to take a look at the code changes you make so I can learn from that and submit some PRs as well, as this isn't the most exciting work I know :)

Have had to do accessibility stuff (I'm sure we're breaking a few rules there as well, intend to adjust some colors, but after we hook everything up) ... and it's even less fun.

Screen Shot 2022-04-02 at 4 26 09 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants