Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve toggle switch #22

Closed
2 tasks
Tracked by #7
dstrukt opened this issue Jan 29, 2022 · 4 comments
Closed
2 tasks
Tracked by #7

Improve toggle switch #22

dstrukt opened this issue Jan 29, 2022 · 4 comments

Comments

@dstrukt
Copy link
Member

dstrukt commented Jan 29, 2022

  • Add helper text variant
  • Better formatting

Screen Shot 2022-03-10 at 5 52 24 PM

@dstrukt
Copy link
Member Author

dstrukt commented Mar 11, 2022

Updates.

@dennisreimann
Copy link
Member

What's the diffrence with the "Better formatting"?

The helper text variant can be solved with the general Bootstrap layout utilities, we do not ned to define a custom component for that imho.

@dennisreimann
Copy link
Member

Can we close this? As far as I see we don't need to customize the component and should use the Bootstrap utils for applying the helper text.

@dstrukt
Copy link
Member Author

dstrukt commented Apr 19, 2022

That's a fair point .. took a look at the code of how we're implementing the switches and agree with you, as long as it's consistent in the implementation, which it seemed to be, I'm cool with that.

I suppose the only other changes to the switches could be off/on hover states, but that's just more minor interactive stuff that could be done at any time.

Screen Shot 2022-04-19 at 10 30 56 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants