Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PayJoin] Add onion to BIP21 uri if onion store is visited #2411

Closed
MaxHillebrand opened this issue Mar 31, 2021 · 4 comments
Closed

[PayJoin] Add onion to BIP21 uri if onion store is visited #2411

MaxHillebrand opened this issue Mar 31, 2021 · 4 comments
Assignees
Labels

Comments

@MaxHillebrand
Copy link
Contributor

Describe the bug
If a store has PayJoin activated, and is also available at a onion server, then the BIP21 URI of the invoice still uses the clearnet domain in the pj field. I think the expected behavior would be to add the onion link into the BIP21 URI. As the user reached BTCPay through Tor browser, the default should be that the user stays within the Tor network, and does not use clearnet to negotiate the PayJoin.

To Reproduce the bug
Steps to reproduce the reported bug:

  1. Go to m33g5t4itjerxhf2vuyrxahstcuhshfxzl2qy5mcuhti3m5erzh5y2yd.onion, the onion address of https://payjoin.test.kukks.org/
  2. Click on an Item
  3. Go to the Copy view of the invoice
  4. See that BIP21 URI has the clearnet domain.

Expected behavior

If user reaches BTCPay through Tor, it should show the onion link in the BIP21 URI

Screenshots

screenshot_20210331_140422

Additional context

This might not be unexpected, as maybe the rational is that most wallets who do support BIP21 URI, do not support Tor and reaching an onion server.

@Kukks
Copy link
Member

Kukks commented Mar 31, 2021

ACK, this is more of a bug than a feature request

EDIT: oops it is described as a bug

@Kukks Kukks added the Bug label Mar 31, 2021
@Kukks Kukks added this to To-Do 📝 in 0.14 May 3, 2021
@Kukks
Copy link
Member

Kukks commented May 5, 2021

I have not been able to replicate in my environments.. Everytime I visit btcpay on an hidden service, the URL in the bip21 reflects it

@Kukks
Copy link
Member

Kukks commented May 5, 2021

Perhaps it could be an issue with a forwarded header somewhere.

@MaxHillebrand
Copy link
Contributor Author

This was a bug in https://github.com/Kixunil/cryptoanarchy-deb-repo-builder/, @Kixunil fixed it and it's working properly now.

sorry for opening in the wrong repo :)

@pavlenex pavlenex removed this from To-Do 📝 in 0.14 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants