Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wallet Transactions view & pagination functionality #3954

Open
3 of 5 tasks
dstrukt opened this issue Jul 11, 2022 · 5 comments
Open
3 of 5 tasks

Improve Wallet Transactions view & pagination functionality #3954

dstrukt opened this issue Jul 11, 2022 · 5 comments
Assignees

Comments

@dstrukt
Copy link
Member

dstrukt commented Jul 11, 2022

As originally requested by @NicolasDorier on MM, summarized a high-level list of tasks he requested + some tasks for consideration while we tackle the original request, if this should be broken down further into sub-tasks for implementation, please let me know.

  • Load 1 month's worth of transactions by default
  • Add a "Load/View More" button at the bottom of the scroll view, which triggers the loading of the next month of transactions
  • Either continue to show another button the user must click until the end of the list of transactions OR hitting the bottom of the view triggers the infinite scroll with no additional button click necessary .. DECISION NEEDED
  • Add support for search, specifically for TX id
  • Add support for date range filter (similar to what we'll do for the Invoice view) .. DECISION NEEDED

Accompanying mock to be posted soon.

@HamroRamro
Copy link
Contributor

PR #4074 up for review for 1 through 3 , @dstrukt

@dstrukt dstrukt removed their assignment Sep 19, 2022
@pavlenex pavlenex added this to the 1.9.0 milestone Dec 19, 2022
@pavlenex
Copy link
Contributor

pavlenex commented Mar 6, 2023

@dstrukt Can you elaborate what's left for this one? Do you have any screens ready or is this perhaps entirely done?

@dennisreimann
Copy link
Member

We can revisit this once #4914 is done, because the remainders here sound like we can simply reuse the patterns we are about to establish in the invoices list.

@dstrukt
Copy link
Member Author

dstrukt commented May 6, 2023

@dennisreimann Is correct, we can revisit this ticket with some of the patterns we're establishing, as well as #3872 & #3871

@dstrukt dstrukt removed this from the 1.9.0 milestone May 6, 2023
@AbsurdlySuspicious
Copy link

Would also be nice:

  • "Only IN/OUT transactions" filter
  • "No label" filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@dennisreimann @dstrukt @pavlenex @AbsurdlySuspicious @HamroRamro and others