Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoS Without Derivation Scheme #483

Closed
britttttk opened this issue Jan 2, 2019 · 3 comments
Closed

PoS Without Derivation Scheme #483

britttttk opened this issue Jan 2, 2019 · 3 comments

Comments

@britttttk
Copy link
Contributor

You can create a PoS App, with a store that doesn't have a derivation scheme, and when you create an invoice with the App it shows this error to the user.

image

@pavlenex
Copy link
Contributor

pavlenex commented Jan 2, 2019

There's nothing we can do besides not allowing the users to create app when no store and derivation scheme is added, but that's also weird UX.

It's not just the PoS, the upcoming #313 also has this problem.
I think the actual problem here is improving the error messages #275
If the error messages were better users would know what to do.

@pavlenex pavlenex added the App label Jan 4, 2019
@Kukks
Copy link
Member

Kukks commented Jan 12, 2019

I think it's fair to allow it but maybe display a big red sticky warning while editing the POS or viewing it that you can't create invoices.

@britttttk
Copy link
Contributor Author

Closing this because the error message is now very clear for both PoS and CF in this situation.

{"error":"Warning: No wallet has been linked to your BTCPay Store. See the following link for more information on how to connect your store and wallet. (https://docs.btcpayserver.org/btcpay-basics/gettingstarted#connecting-btcpay-store-to-your-wallet)\r\n2/4/2019 8:53:50 AM: Creation of invoice starting\r\n"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants