Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluginize Webhooks and support Payouts #5421

Merged
merged 21 commits into from Dec 1, 2023

Conversation

Kukks
Copy link
Member

@Kukks Kukks commented Oct 24, 2023

This PR makes the webhook system easily extendable by simply implementing IWebhookProvider. There should be no breaking changes. It also introduces new webhooks for Payouts

closes #5356

@Kukks Kukks force-pushed the pluginize-webhooks branch 4 times, most recently from 446ff38 to bb8c23b Compare October 24, 2023 12:42
@Kukks Kukks added this to the 1.12.0 milestone Oct 25, 2023
Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@dennisreimann
Copy link
Member

dennisreimann commented Oct 25, 2023

Nice! Based on this I'd add webhooks for payment requests, so that we can then tackle #461 via the subscriptions plugin :)

@dennisreimann
Copy link
Member

Rebased and added hints for the email related things:

Payment Request

Warn if there are no email rules

payreq

Email Rules

Notify about the server fallback being used

email-fallback

Update placeholder display

grafik

@dennisreimann
Copy link
Member

Will fix the tests.

@dennisreimann
Copy link
Member

Added 3fd4582 to ensure the StoreId is set for StoreWebhookEvents, because WebhookProvider.ProcessEvent needs it when calling webhookSender.GetWebhooks.

Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Kukks Kukks merged commit a97172c into btcpayserver:master Dec 1, 2023
3 checks passed
@Kukks Kukks deleted the pluginize-webhooks branch December 1, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Payment request link trigger for email rules setting and remove redundant message in the UI
3 participants