Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-refference Greenfield API view in the Legacy API view #5571

Closed
pavlenex opened this issue Dec 20, 2023 · 5 comments
Closed

Cross-refference Greenfield API view in the Legacy API view #5571

pavlenex opened this issue Dec 20, 2023 · 5 comments
Labels
good first issue UI / UX Front-end issues, for front-end designers
Milestone

Comments

@pavlenex
Copy link
Contributor

Context:

When started, BTCPay Server had a BitPay-compatible API, which to this day still works. However, due to various limitation of that API, and BTCPay growing as a stack, we introduced Greenfield API which allows pretty much to run BTCPay headlessly.

The difference between the two API's is that Greenfield API is account based, where as, BitPay compatible (legacy) API is store based. This is currently reflected in BTCPay's UI, where Store Settings > Access Tokens showcases Legacy (BitPay compatible API), and Account > Manage > API Keys is for Greenfield.

Problem:

While we mention (link to) the legacy api on the Account > Manage > API Keys, we do not do the same on the Legacy API page in Store Settings > Access Tokens, which often leads people using Greenfield to enter legacy API keys and face problems.
Screenshot 2023-12-20 at 11 51 51

Proposed solution:

I think besides simple linking to the Account Manage API Keys page, we may also want to add a bit of context so developers building on top of BTCPay don't face this barriers from the get go.

"On this page  you can manage Legacy (BitPay compatible) API keys, which are store-based. For the new Greenfield API, please generate your API keys [here]."
Screen.Recording.2023-12-20.at.11.52.12.mov

Before doing a PR, it would be good if we can first discuss the proposed copy and see if it needs to be ironed out. And how specifically we want to add this text according to our style guidelines cc @dstrukt

@pavlenex pavlenex added UI / UX Front-end issues, for front-end designers good first issue labels Dec 20, 2023
@pavlenex pavlenex added this to the 1.13.0 milestone Dec 20, 2023
@lukeist
Copy link
Contributor

lukeist commented Dec 26, 2023

While we mention (link to) the legacy api on the Account > Manage > API Keys, we do not do the same on the Legacy API page in Store Settings > Access Tokens, which often leads people using Greenfield to enter legacy API keys and face problems.

I'm experiencing the same issue.

I've been struggling to use the legacy API instead of the Greenfield API. I kept wondering why it wasn't working. The Greenfield API documentation doesn't mention the need to go to Account > Manage > API keys. I initially thought the legacy API was the same as the Greenfield API until I came across this.

Before doing a PR, it would be good if we can first discuss the proposed copy and see if it needs to be ironed out. And how specifically we want to add this text according to our style guidelines cc @dstrukt

I want to help with this issue. Who should I talk to about it??

@pavlenex
Copy link
Contributor Author

We can discuss possible improvements here @hiluan.

Greenfield API documentation doesn't mention the need to go to Account > Manage > API keys

This is problematic and should be addressed imo. Also related #5572

Would be at least useful to note all of this struggles you're facing, and then let's figure out how to improve that experience.

@lukeist
Copy link
Contributor

lukeist commented Dec 27, 2023

It would be great to have a direct link or button under Store Settings > Access Tokens for creating a Greenfield API Key, like "For Greenfield API Key, click here." Alternatively, a button like "Generate Greenfield API keys" directly in that section could work.

If a dedicated button isn't possible, please guide users on how to generate Greenfield API keys by adding a clear reference in the Greenfield API documentation, such as 'Generate a Greenfield API Key: go to Account > Manage > API keys.'

I finally got the right API key today from "Account > Manage > API keys," and it's working well. However, to improve user experience, in the Greenfield doc, it would be helpful to include sample codes for different languages, not just responses. For example:
Screenshot 2023-12-26 193451
https://finnhub.io/docs/api/company-basic-financials

Screenshot 2023-12-26 193236
https://stripe.com/docs/upgrades/manage-payment-methods

@lukeist
Copy link
Contributor

lukeist commented Jan 2, 2024

I made a small change by adding this:
Screenshot 2024-01-01 203900

Let me know what you think. Thanks!

@Kukks
Copy link
Member

Kukks commented Jan 3, 2024

fixed in #5635

@Kukks Kukks closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue UI / UX Front-end issues, for front-end designers
Projects
Development

No branches or pull requests

3 participants