Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Checkout v2 copy on QR code does not have lightning invoice #5625

Closed
1 task done
iBobik opened this issue Dec 26, 2023 · 2 comments · Fixed by #5627
Closed
1 task done

[Bug]: Checkout v2 copy on QR code does not have lightning invoice #5625

iBobik opened this issue Dec 26, 2023 · 2 comments · Fixed by #5627
Assignees
@dennisreimann
Labels
Bug Checkout
Milestone
1.12.x

Comments

@iBobik
Copy link

iBobik commented Dec 26, 2023

What is your BTCPay version?

v1.11.7+a921504bc

How did you deploy BTCPay Server?

Docker

What happened?

QR code is correct, texts under it is correct, but when I click on the QR code it will copy only on-chain address.

How did you encounter this bug?

Created invoice and clicked on the QR code.

Relevant log output

No response

What browser do you use?

Safari

Additional information

No response

Are you sure this is a bug report?

  • I confirm this is a bug report
@dennisreimann dennisreimann self-assigned this Dec 26, 2023
@pavlenex
Copy link
Contributor

pavlenex commented Dec 26, 2023 •
edited

Alright, replicated, so the issue is not scanning, but clicking on the QR. Happens with 1.2.3 as well.

@pavlenex pavlenex added this to the 1.12.x milestone Dec 26, 2023
@iBobik
Copy link
Author

iBobik commented Dec 26, 2023 via email

dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Dec 27, 2023
@dennisreimann
Checkout v2: Clicking QR code copies full payment URI
793ae04 
Before it copied only the destination value (Bitcoin address or Lightning BOLT11). This didn't include the BOLT11 in case of the unified QR code. Now it will copy the full payment URI, which is the same as the QR represents:

- Unified: `bitcoin:ADDRESS?amount=AMOUNT&lightning=BOLT11`
- Bitcoin: `bitcoin:ADDRESS?amount=AMOUNT`
- Lightning: `lightning:BOLT11`

Fixes btcpayserver#5625.
@dennisreimann dennisreimann mentioned this issue Dec 27, 2023
Merged
Kukks pushed a commit that referenced this issue Jan 16, 2024
@dennisreimann
Checkout v2: Clicking QR code copies full payment URI (#5627)
89d2945 
* Checkout v2: Clicking QR code copies full payment URI

Before it copied only the destination value (Bitcoin address or Lightning BOLT11). This didn't include the BOLT11 in case of the unified QR code. Now it will copy the full payment URI, which is the same as the QR represents:

- Unified: `bitcoin:ADDRESS?amount=AMOUNT&lightning=BOLT11`
- Bitcoin: `bitcoin:ADDRESS?amount=AMOUNT`
- Lightning: `lightning:BOLT11`

Fixes #5625.

* Test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennisreimann dennisreimann

Labels
Bug Checkout
Projects
BTCPay Server Roadmap 🛣️
Archived in project
Milestone
1.12.x
Development

Successfully merging a pull request may close this issue.

Checkout v2: Clicking QR code copies full payment URI dennisreimann/btcpayserver
3 participants
@dennisreimann @iBobik @pavlenex