Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS Keypad "menu" button is only visible when a users role is btcpay.store.canmodifystoresettings #5698

Closed
1 task done
BuffaloDyl opened this issue Jan 24, 2024 · 0 comments · Fixed by #5702
Closed
1 task done
Assignees
Labels
Bug PoS Point of Sale app UI / UX Front-end issues, for front-end designers
Milestone

Comments

@BuffaloDyl
Copy link

What is your BTCPay version?

BTCPay Server v1.12.3+f23078df1

How did you deploy BTCPay Server?

Docker

What happened?

When viewing the POS Keypad, the 'Menu/View Recent Invoices' button is only visible when a users role is "btcpay.store.canmodifystoresettings"

I believe this should be changed to canviewinvoices and higher

How did you encounter this bug?

Add new user to store with role btcpay.store.canmodifyinvoices, the menu does not appear on POS keypad

Relevant log output

No response

What browser do you use?

No response

Additional information

No response

Are you sure this is a bug report?

  • I confirm this is a bug report
@dennisreimann dennisreimann self-assigned this Jan 25, 2024
@dennisreimann dennisreimann added Bug UI / UX Front-end issues, for front-end designers PoS Point of Sale app labels Jan 25, 2024
@pavlenex pavlenex added this to the 1.12.x milestone Jan 25, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Jan 25, 2024
Fixes btcpayserver#5698. Before this, the app lookup was constrained by the user having at least `CanModifyStoreSettings` permissions. This changes it to require the user being associated with a store, leaving the fine-grained authorization checks up to the individual actions.
NicolasDorier pushed a commit that referenced this issue Jan 25, 2024
Fixes #5698. Before this, the app lookup was constrained by the user having at least `CanModifyStoreSettings` permissions. This changes it to require the user being associated with a store, leaving the fine-grained authorization checks up to the individual actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PoS Point of Sale app UI / UX Front-end issues, for front-end designers
Projects
Development

Successfully merging a pull request may close this issue.

3 participants