Make sure end date is after start date in Crowdfund app #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolatovumar
commented
Aug 28, 2022
| @@ -374,7 +380,13 @@ private async Task<string> GetStoreDefaultCurrentIfEmpty(string storeId, string | |||
| { | |||
| if (string.IsNullOrWhiteSpace(currency)) | |||
| { | |||
| currency = (await _storeRepository.FindStore(storeId)).GetStoreBlob().DefaultCurrency; | |||
| var store = await _storeRepository.FindStore(storeId); | |||
| if (store == null) | |||
There was a problem hiding this comment.
store can be null here technically so we need to check for that.
| </div> | ||
| <span asp-validation-for="StartDate" class="text-danger"></span> |
There was a problem hiding this comment.
Placed these below both of the elements so the layout doesn't get messed up if there is an error.
| @@ -287,12 +288,17 @@ public async Task<IActionResult> UpdateCrowdfund(string appId, UpdateCrowdfundVi | |||
|
|
|||
| if (Enum.Parse<CrowdfundResetEvery>(vm.ResetEvery) != CrowdfundResetEvery.Never && !vm.StartDate.HasValue) | |||
| { | |||
| ModelState.AddModelError(nameof(vm.StartDate), "A start date is needed when the goal resets every X amount of time."); | |||
| ModelState.AddModelError(nameof(vm.StartDate), "A start date is needed when the goal resets every X amount of time"); | |||
There was a problem hiding this comment.
Removed a period character at the end since other errors don't have it.
| } | ||
|
|
||
| if (Enum.Parse<CrowdfundResetEvery>(vm.ResetEvery) != CrowdfundResetEvery.Never && vm.ResetEveryAmount <= 0) | ||
| { | ||
| ModelState.AddModelError(nameof(vm.ResetEveryAmount), "You must reset the goal at a minimum of 1 "); | ||
| ModelState.AddModelError(nameof(vm.ResetEveryAmount), "You must reset the goal at a minimum of 1"); |
There was a problem hiding this comment.
There was an extra trailing space here which I removed.
bolatovumar
force-pushed
the
crowdfund-date-validation
branch
from
5f2b179
to
2ee4539
Compare
|
Failing test unrelated
|
|
tACK, nice catch |
dstrukt
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we don't validate that end date is after start date in the crowdfund app. We should probably check for this. This PR adds this check.