Form Builder #4137

Kukks · 2022-09-19T08:46:17Z

Closes #505

dennisreimann · 2022-10-26T21:15:37Z

@Kukks It'd be good to move the generic form definitions (email, address) out of the view code into C#, so that we can use them there as well and then serialize it to JSON for the view.

Other than that I'd consider this PR done and would like to see it merged, so that I can use the forms in Checkout v2.

Kukks · 2022-10-30T10:14:13Z

@Kukks It'd be good to move the generic form definitions (email, address) out of the view code into C#, so that we can use them there as well and then serialize it to JSON for the view.

Other than that I'd consider this PR done and would like to see it merged, so that I can use the forms in Checkout v2.

done

dennisreimann · 2022-10-31T09:03:54Z

@Kukks Anything else that's left TODO here? Otherwise, let's get this in :)

Kukks · 2022-11-09T07:48:34Z

Add tests
Integrate into pos
integrate into crowdfund -- 1.7.x instead
greenfield API -- 1.7.x instead
form UI editor -- 1.8
integrate into pay button -- 1.8
integrate into pay request (tricky)
[ x] integrate into invoice

dennisreimann · 2022-11-16T13:58:25Z

BTCPayServer/Controllers/UIStoresController.cs

+            blob.CheckoutFormId = model.CheckoutFormId;
            if (blob.CheckoutType == Client.Models.CheckoutType.V2)
            {
-                blob.CheckoutFormId = model.CheckoutFormId;


What difference does this make? I put it into the if to prevent unintended changes in case Checkout v2 isn't used.

As the value is submitted every time with the form it wouldn't change, but I was wondering about the intention of pulling it out

This is because forms are no longer tied to requiring checkout v2 - they work perfectly fine with old-style checkout too.

Ah ok, in that case we should also update the view to have the select dislayed in any case. I can update that.

dennisreimann · 2022-11-16T14:02:55Z

BTCPayServer/Forms/UIFormsController.cs

+
+    [AllowAnonymous]
+    [HttpGet("~/forms/{id}")]
+    public async Task<IActionResult> ViewForm(string id, string redirectUrl)


This won't work, as the user can then manipulate the original data in the query string and the invoice might be created based on the modified data.

For the simple POS item list it works, because the price cannot be decreased (because the price is taken from the item), but for the cart view it can be manipulated — I think we should come up with a more resilient approach here.

The logic for the cart is still acted upon as before. If the user manipulated the form HTML values before submitting, it would have the same result

I see; however that isn't ideal. It works as long as the merchant has most likely the control over the input device (as with the POS), but it'd be problematic for e.g. an online store.

One idea here: We could hash the data (or amount) with a salt saved in the store settings and use that as a checksum on the receiving action. That way we can ensure that the data doesn't get tampered in the browser..

BTCPayServer/Forms/UIFormsController.cs

pavlenex · 2022-11-18T17:59:07Z

@Kukks @dennisreimann is this supposed to work with new checkout, because it doesn't?

dennisreimann · 2022-11-18T18:20:06Z

@pavlenex Keep in mind that not all invoice creation methods are covered yet. See this comment.

pavlenex · 2022-11-19T18:00:28Z

I tried this PR again, but after some recent pushes I am experiencing a few problems, which are mostly do to me selecting default options. For example payment requests work with shipping address and email address but not with other options, explained below.

Problem 1: Default store settings give 404 or crashed

Deployed a new store
Did not touch default settings
Go to Payment request (leave it to inherit store settings)
Get this error

System.NullReferenceException: Object reference not set to an instance of an object.
   at BTCPayServer.Plugins.PointOfSale.Controllers.UIPointOfSaleController.ViewPointOfSale(String appId, Nullable`1 viewType, Nullable`1 amount, String email, String orderId, String notificationUrl, String redirectUrl, String choiceKey, String posData, RequiresRefundEmail requiresRefundEmail, CancellationToken cancellationToken) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Plugins/PointOfSale/Controllers/UIPointOfSaleController.cs:line 207
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextExceptionFilterAsync>g__Awaited|26_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ExceptionContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at BTCPayServer.Hosting.BTCPayMiddleware.Invoke(HttpContext httpContext) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Hosting/BTCpayMiddleware.cs:line 100
   at BTCPayServer.Hosting.GreenfieldMiddleware.Invoke(HttpContext httpContext) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Hosting/GreenfieldMiddleware.cs:line 30
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at BTCPayServer.Hosting.HeadersOverrideMiddleware.Invoke(HttpContext httpContext) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Hosting/HeadersOverrideMiddleware.cs:line 29
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)
2022-11-19 18:55:54.236 +01:00 [INF] BTCPayServer.Services.PaymentRequests.PaymentRequestUpdated

Problem 2 When selecting `do not request address` in payment request, I can't generate an invoice

Create payment request
Select Do not request any information
CTA is fill out the form (incorrect)
Click on the button
Nothing happens
Console logs show this

Kukks · 2022-11-20T10:03:15Z

I tried this PR again, but after some recent pushes I am experiencing a few problems, which are mostly do to me selecting default options. For example payment requests work with shipping address and email address but not with other options, explained below.

Problem 1: Default store settings give 404 or crashed

Deployed a new store
Did not touch default settings
Go to Payment request (leave it to inherit store settings)
Get this error

System.NullReferenceException: Object reference not set to an instance of an object.
   at BTCPayServer.Plugins.PointOfSale.Controllers.UIPointOfSaleController.ViewPointOfSale(String appId, Nullable`1 viewType, Nullable`1 amount, String email, String orderId, String notificationUrl, String redirectUrl, String choiceKey, String posData, RequiresRefundEmail requiresRefundEmail, CancellationToken cancellationToken) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Plugins/PointOfSale/Controllers/UIPointOfSaleController.cs:line 207
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextExceptionFilterAsync>g__Awaited|26_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ExceptionContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at BTCPayServer.Hosting.BTCPayMiddleware.Invoke(HttpContext httpContext) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Hosting/BTCpayMiddleware.cs:line 100
   at BTCPayServer.Hosting.GreenfieldMiddleware.Invoke(HttpContext httpContext) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Hosting/GreenfieldMiddleware.cs:line 30
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at BTCPayServer.Hosting.HeadersOverrideMiddleware.Invoke(HttpContext httpContext) in /Users/p/Downloads/pavlenex/btcpayserver/BTCPayServer/Hosting/HeadersOverrideMiddleware.cs:line 29
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)
2022-11-19 18:55:54.236 +01:00 [INF] BTCPayServer.Services.PaymentRequests.PaymentRequestUpdated

Problem 2 When selecting `do not request address` in payment request, I can't generate an invoice

Create payment request
Select Do not request any information
CTA is fill out the form (incorrect)
Click on the button
Nothing happens
Console logs show this

Thanks for testing, fixed a bunch of issues today that I found. Let me know if it's a bit better.

pavlenex · 2022-11-21T10:33:38Z

@Kukks Thanks, the Payment request bug is no longer present, however I am still getting error when creating a POS with default settings, it gives 404.

To replicate:

Create a store with default settings (do not set form builder, just default)
Create a POS with any view (keypad, cart, etc)
Try to pay or generate an invoice
404
Not getting any logs

Note, it needs to have inherit store settings which is default not to collect any information on the app level or to have `do not to replicate to do a 404 crash. When you select either email or address it doesn't crash.

Screen.Recording.2022-11-21.at.11.32.21.mov

Also these two options are kinda the same on POS view? Should we remove one?

NicolasDorier · 2022-11-24T12:20:40Z

There are too many magic and rough edge in this code for me to be confident it is in a shippable state.

For example, I found a bug during review: there is a few "pre-made" forms. Those doesn't have a storeId associated, and such routes such as [HttpPost("~/forms/{id?}")] would crash.

NicolasDorier · 2022-11-24T12:35:27Z

This isn't ready yet.

what is formResponse in payment request?
why checkoutFormId is removed?
Shouldn't use TempData for flowing data like this, it's not done for that, instead should use PostRedirect
Missing index on Form StoreId
No tests written for CRUD of custom forms
Why isn't it possible to get a form for a normal invoice, without payment request/crowdfund?
At someplace, we rely on FormData.StoreId however, this isn't set for preset templates such as Email and Address.

Kukks · 2022-11-24T13:05:11Z

This isn't ready yet.

what is formResponse in payment request?

why checkoutFormId is removed?

Shouldn't use TempData for flowing data like this, it's not done for that, instead should use PostRedirect

Missing index on Form StoreId

No tests written for CRUD of custom forms

Why isn't it possible to get a form for a normal invoice, without payment request/crowdfund?

Form response stores the response from the response if a formid is set

Invoice level form was removed because we were overcomplicating things for a feature that is probably not very useful. We can add it later.

Checkoutformid was removed along with the above point, for the same reason.

Custom forms may not be very used for now, since we haven't built a UI for building a form. We can potentially just hide it behind an experimental flag for now

dennisreimann · 2022-11-24T14:12:36Z

Let's just use the preconfigured/generic forms (email and address) in the first iteration and add customizable forms later.

Kukks · 2022-11-24T15:14:23Z

I would not remove, just hide behind experimental flag.

…

On Thu, Nov 24, 2022, 3:12 PM d11n ***@***.***> wrote: Let's just use the preconfigured/generic forms (email and address) in the first iteration and add customizable forms later. — Reply to this email directly, view it on GitHub <#4137 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN357QBF2TLYUBKZSTNYX3WJ5ZV7ANCNFSM6AAAAAAQP4PRIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

pavlenex · 2022-11-24T15:15:12Z

Awkward question, but where can one find customizable forms. Are they even in the UI? The only forms I found so far were in the apps and pre-defined?

Kukks · 2022-11-24T15:18:06Z

Store settings, secondary nav

…

On Thu, Nov 24, 2022, 4:15 PM Pavlenex ***@***.***> wrote: Awkward question, but where can one find customizable forms. Are they even in the UI? The only forms I found so far were in the apps and pre-defined? — Reply to this email directly, view it on GitHub <#4137 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN357VBFSC3QKHTCRB5DALWJ6BAXANCNFSM6AAAAAAQP4PRIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

pavlenex · 2022-11-24T15:31:06Z

Oh wow, I was blind, totally didn't expect us to have customizable forms in this release. I think we should abstract it from the UI, how about we roll out with the predefined ones, and just see which forms people ask? I think in the next release we may have more time to thinker about the UI here, and the need for more forms.

Kukks · 2022-11-24T15:34:55Z

I would prefer to not entirely remove it and just hide it.

…

On Thu, Nov 24, 2022, 4:31 PM Pavlenex ***@***.***> wrote: Oh wow, I was blind, totally didn't expect us to have customizable forms in this release. I think we should abstract it from the UI, how about we roll out with the predefined ones, and just see which forms people ask? I think in the next release we may have more time to thinker about the UI here, and the need for more forms. — Reply to this email directly, view it on GitHub <#4137 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN357TNJ7CE56EOPDDWOJDWJ6C4JANCNFSM6AAAAAAQP4PRIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

dennisreimann

Refactored it to remove the TempData usages. To me the flows for POS and payment requests seem to be clean and intuitive now.

Also trimmed off the parts where we had custom forms (from the UI, the code is still there) so that we‘ll only ship the generic forms (email and address).

dennisreimann · 2022-11-24T23:31:49Z

@NicolasDorier I've added the index for StoreId, but couldn't generate the migration — can you do that once you are back?

NicolasDorier · 2022-11-25T01:03:56Z

I remove untested code and the database code.
There was some bugs in there that wasn't detected because it wasn't tested or probably not even used.

I will reopen a PR rebased with the stuff I just removed after this one so @Kukks can improve it in a separate PR.

NicolasDorier · 2022-11-25T01:53:53Z

I've opened a PR adding back what I removed for supporting Generic Forms. We should do in a future PR after this release.

Kukks force-pushed the form_builder branch 4 times, most recently from be0bb6c to d085707 Compare September 20, 2022 12:16

dennisreimann force-pushed the form_builder branch from d085707 to 6c4fbde Compare September 23, 2022 16:06

dennisreimann mentioned this pull request Sep 24, 2022

Checkout v2 #4157

Merged

dstrukt self-requested a review October 20, 2022 17:49

Kukks force-pushed the form_builder branch from 48c6a1d to 0df7d90 Compare October 30, 2022 10:12

dennisreimann approved these changes Oct 31, 2022

View reviewed changes

dennisreimann mentioned this pull request Nov 2, 2022

Checkout v2 finetuning #4261

Closed

30 tasks

Kukks force-pushed the form_builder branch 5 times, most recently from 34f8374 to da77d21 Compare November 15, 2022 10:49

dennisreimann reviewed Nov 16, 2022

View reviewed changes

Kukks force-pushed the form_builder branch from 12cdb4b to d4a5622 Compare November 18, 2022 10:20

Kukks mentioned this pull request Nov 18, 2022

Validate cart cost with explicit amount #4307

Merged

Kukks force-pushed the form_builder branch from 667a04e to e4d21bb Compare November 19, 2022 10:31

pavlenex mentioned this pull request Nov 19, 2022

Add field validation for Shipping address #4317

Closed

pavlenex mentioned this pull request Nov 21, 2022

Fix build warnings UIFormsControllerUIPaymentRequestController #4323

Closed

NicolasDorier added 2 commits November 24, 2022 21:15

Fix modify

50d08de

Remove storeId from step form

9c88c53

Remove useless storeId parameter

3cb7c64

dennisreimann added 8 commits November 24, 2022 17:03

Merge branch 'master' into form_builder

3e1511c

Hide custom form feature in UI

7218c30

Minor cleanups

ad17234

Remove custom form options from select for now

dcade8b

More minor syntax cleanups

82a6906

Update test

713b87d

Add index - needs migration

8b7b772

Refactoring: Use PostRedirect instead of TempData for data transfer

4b95264

dennisreimann approved these changes Nov 24, 2022

View reviewed changes

Remove untested and unfinished code

71c2bff

NicolasDorier added 2 commits November 25, 2022 10:12

formResponse should be a JObject, not a string

315a771

Fix case for Form type

13cb895

NicolasDorier merged commit 0222858 into master Nov 25, 2022

NicolasDorier deleted the form_builder branch November 25, 2022 01:42

NicolasDorier mentioned this pull request Nov 25, 2022

Generic Forms #4346

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Form Builder #4137

Form Builder #4137

Kukks commented Sep 19, 2022 •

edited by pavlenex

dennisreimann commented Oct 26, 2022

Kukks commented Oct 30, 2022

dennisreimann commented Oct 31, 2022

Kukks commented Nov 9, 2022 •

edited

dennisreimann Nov 16, 2022

Kukks Nov 16, 2022

dennisreimann Nov 16, 2022 •

edited

dennisreimann Nov 16, 2022

Kukks Nov 16, 2022

dennisreimann Nov 16, 2022

dennisreimann Nov 21, 2022

pavlenex commented Nov 18, 2022

dennisreimann commented Nov 18, 2022

pavlenex commented Nov 19, 2022 •

edited

Kukks commented Nov 20, 2022

Problem 1: Default store settings give 404 or crashed

Problem 2 When selecting `do not request address` in payment request, I can't generate an invoice

pavlenex commented Nov 21, 2022 •

edited

NicolasDorier commented Nov 24, 2022

NicolasDorier commented Nov 24, 2022 •

edited

Kukks commented Nov 24, 2022

dennisreimann commented Nov 24, 2022

Kukks commented Nov 24, 2022 via email

pavlenex commented Nov 24, 2022

Kukks commented Nov 24, 2022 via email

pavlenex commented Nov 24, 2022

Kukks commented Nov 24, 2022 via email

dennisreimann left a comment •

edited

dennisreimann commented Nov 24, 2022

NicolasDorier commented Nov 25, 2022

NicolasDorier commented Nov 25, 2022

Form Builder #4137

Form Builder #4137

Conversation

Kukks commented Sep 19, 2022 • edited by pavlenex

dennisreimann commented Oct 26, 2022

Kukks commented Oct 30, 2022

dennisreimann commented Oct 31, 2022

Kukks commented Nov 9, 2022 • edited

dennisreimann Nov 16, 2022

Choose a reason for hiding this comment

Kukks Nov 16, 2022

Choose a reason for hiding this comment

dennisreimann Nov 16, 2022 • edited

Choose a reason for hiding this comment

dennisreimann Nov 16, 2022

Choose a reason for hiding this comment

Kukks Nov 16, 2022

Choose a reason for hiding this comment

dennisreimann Nov 16, 2022

Choose a reason for hiding this comment

dennisreimann Nov 21, 2022

Choose a reason for hiding this comment

pavlenex commented Nov 18, 2022

dennisreimann commented Nov 18, 2022

pavlenex commented Nov 19, 2022 • edited

Problem 1: Default store settings give 404 or crashed

Problem 2 When selecting do not request address in payment request, I can't generate an invoice

Kukks commented Nov 20, 2022

Problem 1: Default store settings give 404 or crashed

Problem 2 When selecting do not request address in payment request, I can't generate an invoice

pavlenex commented Nov 21, 2022 • edited

NicolasDorier commented Nov 24, 2022

NicolasDorier commented Nov 24, 2022 • edited

Kukks commented Nov 24, 2022

dennisreimann commented Nov 24, 2022

Kukks commented Nov 24, 2022 via email

pavlenex commented Nov 24, 2022

Kukks commented Nov 24, 2022 via email

pavlenex commented Nov 24, 2022

Kukks commented Nov 24, 2022 via email

dennisreimann left a comment • edited

Choose a reason for hiding this comment

dennisreimann commented Nov 24, 2022

NicolasDorier commented Nov 25, 2022

NicolasDorier commented Nov 25, 2022

Kukks commented Sep 19, 2022 •

edited by pavlenex

Kukks commented Nov 9, 2022 •

edited

dennisreimann Nov 16, 2022 •

edited

pavlenex commented Nov 19, 2022 •

edited

Problem 2 When selecting `do not request address` in payment request, I can't generate an invoice

Problem 2 When selecting `do not request address` in payment request, I can't generate an invoice

pavlenex commented Nov 21, 2022 •

edited

NicolasDorier commented Nov 24, 2022 •

edited

dennisreimann left a comment •

edited