Wallet transactions: Add label manager #4796
Conversation
| @@ -5,12 +5,14 @@ namespace BTCPayServer.Components.LabelManager | |||
| { | |||
| public class LabelManager : ViewComponent | |||
| { | |||
| public IViewComponentResult Invoke(WalletObjectId walletObjectId, string[] selectedLabels) | |||
| public IViewComponentResult Invoke(WalletObjectId walletObjectId, string[] selectedLabels, bool excludeTypes = true, bool displayInline = false) | |||
There was a problem hiding this comment.
Options that got added for the trasactions list, on which one was able to manage type labels as well. Inline mode is also for the list.
| var walletObjectId = !string.IsNullOrEmpty(type) && !string.IsNullOrEmpty(id) | ||
| ? new WalletObjectId(walletId, type, id) | ||
| : null; | ||
| var labels = walletObjectId == null | ||
| ? await WalletRepository.GetWalletLabels(walletId) | ||
| : await WalletRepository.GetWalletLabels(walletObjectId); |
There was a problem hiding this comment.
It turned out I didn't need this, but this makes it more flexible so that one can request either labels for the whole wallet or individual wallet objects.
| $list.innerHTML += html; | ||
| $list.insertAdjacentHTML('beforeend', html); |
There was a problem hiding this comment.
This did the trick on not removing event listeners from existing TomSelect instances. @Kukks
Co-authored-by: Andrew Camilleri <evilkukka@gmail.com>
Good point, added in e5c5cdc.
|
|
I think you should get rid of |
|
@NicolasDorier The noscript parts got removed. @Kukks I fixed the transaction label info clicks, but couldn't reproduce (Chrome and FF) or find an explanation for the red pixel glitches. Can you try and check the web inspector to see what might be going on there? |
|
The Send page now supports labelling destinations: Additionally, the confirm page shows labels on both inputs and outputs when possible.
|
Uses the label manager component in the wallet transactions list.
Closes #4706
Closes #4755
Also improved the label manager UI to work better with the list: Introduced an inline display mode, which removes the form input appearance. Also adjusted the dropdown and options to fit what we have elsewhere.