Refund updates

[dennisreimann]

Closes #3839. Closes #4812.

• Should alert the user if they're going over pay the refund amount when selecting the custom amount
• An option to also offer a refund LESS the costs involved in issuing the refund (for example onchain fee to send it out)
• Feature Request: Improve Refund Flow for overpaid invoices #4812

[dennisreimann]

An option to also offer a refund LESS the costs involved in issuing the refund (for example onchain fee to send it out)

@Kukks as you initially proposed this one: Is this really necessary now that we have the custom option? It'd also only be helpful for onchain and if we'd calculate the fee in advance.

[Kukks]

An option to also offer a refund LESS the costs involved in issuing the refund (for example onchain fee to send it out)

@Kukks as you initially proposed this one: Is this really necessary now that we have the custom option? It'd also only be helpful for onchain and if we'd calculate the fee in advance.

I'd say yes, as merchants usually don't want to have to calculate themselves, this option could be "send received amount less x% as processing fee', with an input to specify x (0-100% in decimal)

[dennisreimann]

Alright, added it like this:

[dennisreimann]

With regard to this comment: Should we introduce the "minus X%" option as a more general setting which is available in addition to all options? We could simply display it above the "Create refund" button.

@Kukks @petzsch @dstrukt @pavlenex

[Kukks]

With regard to this comment: Should we introduce the "minus X%" option as a more general setting which is available in addition to all options? We could simply display it above the "Create refund" button.

@Kukks @petzsch @dstrukt @pavlenex

That could work, so we move that as some kind of toggle under the options with a link "charge a fee"?

[dennisreimann]

[dennisreimann]

Made the "subtract percentage" option available in general. Ready for review now.

[dstrukt]

Functional tACK.

As discussed on design call, this is a great improvement .. there were some other minor suggestions/ideas to improve the communication/clarity of options, but fell outside of the scope of this PR.

Will revisit some of them (Overpaid, labeling, etc..) in mocks once this is merged!