Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sensitive info #4966

Merged
merged 2 commits into from May 11, 2023
Merged

Conversation

dennisreimann
Copy link
Member

Adds the data-sensitive attribute, which replaces the content of that HTML tag with *** when the "Hide Sensitive Data" mode is on. As this is a feature that only works on the frontend level, the mode is persistsed in the local storage, similar to the chosen color mode.

Closes #3779.

hide-sensitive-info

@dennisreimann dennisreimann added Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers labels May 8, 2023
@dstrukt
Copy link
Member

dstrukt commented May 8, 2023

Oh hell yea! Now everyone down at the coffee shop won't be able to see my 0.0001 bitcoin stack activity either 😂

OP looks great, will get a review in later this evening!

Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have anything to add here, think you cover all the places that are relevant.

LGTM!

@Kukks Kukks merged commit 02110f9 into btcpayserver:master May 11, 2023
4 checks passed
@dennisreimann dennisreimann deleted the hide-sensitive-info branch May 11, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide dashboard balance / hide sensitive data (lurking wife mode)
5 participants